infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

fix: fix update_zuul_project_config script #57

Closed
gtema wants to merge 1 commits from fix-update-zuul into main
pull from: fix-update-zuul
merge into: infra:main
Conversation 3 Commits 1 Files Changed 2 +9 -2
gtema commented 2023-04-04 10:04:34 +00:00
Member
Copy Link

Some of the previous changes broken update_zuul_project_config part of the script responsible for verifying required zuul template is present. It is verifying that, but mistankengly not raising a flag that update is required.

Add also a bit more logging to better understand what is happening

Some of the previous changes broken update_zuul_project_config part of the script responsible for verifying required zuul template is present. It is verifying that, but mistankengly not raising a flag that update is required. Add also a bit more logging to better understand what is happening
gtema added 1 commit 2023-04-04 10:04:34 +00:00
fix: fix update_zuul_project_config script
Some checks failed
gl/check check status: failure (f5daf72598bf21c778b82cd454f8790cfbcb6839)
Details
f5daf72598 
Some of the previous changes broken update_zuul_project_config part of
the script responsible for verifying required zuul template is present.
It is verifying that, but mistankengly not raising a flag that update is
required.
zuul commented 2023-04-04 10:07:42 +00:00
Member
Copy Link

Build failed. https://zuul.otc-service.com/t/gl/buildset/80995dcf2f24404f804b000703ef240c

Build failed. https://zuul.otc-service.com/t/gl/buildset/80995dcf2f24404f804b000703ef240c - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/a2e04b7c14434a33b916cb2d89ac212f): FAILURE in 2m 19s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/d593f78b234a4c1fb50b97c98533812b): SUCCESS in 2m 39s
tischrei requested changes 2023-04-04 10:20:39 +00:00
tischrei left a comment
Owner
Copy Link

Beside of the pep8 issue which needs to be fixed - I’ would prefer that the branch ‘zuul’ is not being created when no change is necessary. But the branch will always be created. This might be a minor improvement.

Beside of the pep8 issue which needs to be fixed - I' would prefer that the branch 'zuul' is not being created when no change is necessary. But the branch will always be created. This might be a minor improvement.
sgode reviewed 2023-04-04 10:21:24 +00:00
tools/update_zuul_project_configs.py
@ -150,3 +150,3 @@
)
for doc in data.docs_by_service_type(service["service_type"]):
logging.debug(f"Analyzing document {doc}")
logging.info("Analyzing document %s" % doc)
sgode commented 2023-04-04 10:21:24 +00:00
Owner
Copy Link

Is there a reason to use the string literal instead of f-strings? In my opinion f-strings are better to read in code.

Is there a reason to use the string literal instead of f-strings? In my opinion f-strings are better to read in code.
gtema commented 2023-05-17 16:31:20 +00:00
Author
Member
Copy Link

https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/ - it is recommended (and if I remember correctly some of the python validators complain on those) to use regular % formatting instead of fstrings explicitly in logging

https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/ - it is recommended (and if I remember correctly some of the python validators complain on those) to use regular % formatting instead of fstrings explicitly in logging
sgode closed this pull request 2024-01-17 14:30:33 +00:00
Some checks failed
gl/check check status: failure (f5daf72598bf21c778b82cd454f8790cfbcb6839)
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
tischrei
Labels
Clear labels
gate
Gate it
gate
Gate it
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
A200014817 ansideln cicd ikvrivis magnus otcbot proposalbot sgode smartyno tischrei vhasko vladimirhasko vladimirvshivkov vvshivko zuul
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infra/otc-metadata#57
No description provided.
Delete Branch "fix-update-zuul"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?