infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

Attention List #4

Closed
sgode wants to merge 16 commits from (deleted):attention_list into main
pull from: (deleted):attention_list
merge into: infra:main
Conversation 3 Commits 16 Files Changed 1 +466
sgode commented 2022-09-27 13:25:05 +00:00
Owner
Copy Link
sgode added 14 commits 2022-09-27 13:25:06 +00:00
Repo+Pull 92a057cb1b
Failure list 9bb5330068
Removed token + made it mandatory b790807bd3
add methods 2b9f70d559
GitHub first try b71f45c846
first time successful run 5466630a41
some changes 78184c5217
update to class be58f093a4
Refactored gitea integration 127642128e
Some pep8 fixes 8c13133c60
spelling mistake 841bda3ac7
json return and error codes 9539863e5f
add comments f2fd5494c1
first alpha d774cc2e8f
Ghost commented 2022-09-27 13:26:22 +00:00
Copy Link

I am a participant lul

I am a participant lul
gtema requested changes 2022-09-28 10:11:13 +00:00
tools/attention_list.py Outdated
@ -0,0 +58,4 @@
parser = argparse.ArgumentParser(
description='Bootstrap repositories.')
parser.add_argument(
'--gh-orgs',
gtema commented 2022-09-28 10:06:40 +00:00
Member
Copy Link

actually instead of that I was expecting rather going through current metadata analyzing only repositories that we care about (smth like in any other script). Please adapt to to consume metadata and rather take parameters “environment” which is then set in the metadata

actually instead of that I was expecting rather going through current metadata analyzing only repositories that we care about (smth like in any other script). Please adapt to to consume metadata and rather take parameters "environment" which is then set in the metadata
Ghost commented 2022-09-28 13:16:01 +00:00
Copy Link

we added the option to provide the token as metadata. Do you think the other stuff should also be added there or what did you mean?

Regarding the git sources: We build the script to use it as a general tool. If it should gather the data from metadata, we will do this or try to do this.

we added the option to provide the token as metadata. Do you think the other stuff should also be added there or what did you mean? Regarding the git sources: We build the script to use it as a general tool. If it should gather the data from metadata, we will do this or try to do this.
tools/attention_list.py Outdated
@ -0,0 +117,4 @@
while True:
try:
req_url = (url
gtema commented 2022-09-28 10:09:02 +00:00
Member
Copy Link

you can either use existing SDK or at least make a wrapper for requests so that you do not repeat the same exception handling block over and over again (smth like in https://review.opendev.org/c/zuul/zuul/+/850008/10/zuul/driver/gitea/giteaconnection.py#364 or in https://github.com/opentelekomcloud/ansible-collection-gitcontrol/tree/main/plugins/module_utils)

you can either use existing SDK or at least make a wrapper for requests so that you do not repeat the same exception handling block over and over again (smth like in https://review.opendev.org/c/zuul/zuul/+/850008/10/zuul/driver/gitea/giteaconnection.py#364 or in https://github.com/opentelekomcloud/ansible-collection-gitcontrol/tree/main/plugins/module_utils)
tools/attention_list.py Outdated
@ -0,0 +157,4 @@
exit()
return pullrequests
def get_failed_gitea_commits(pull, url, gitea_org, repo, headers):
gtema commented 2022-09-28 10:09:46 +00:00
Member
Copy Link

pls decide on function naming convention, get_gitea_failed_commits fits more other functions

pls decide on function naming convention, get_gitea_failed_commits fits more other functions
Ghost commented 2022-09-28 13:13:33 +00:00
Copy Link

done

done
tools/attention_list.py Outdated
@ -0,0 +386,4 @@
)
failed_commits.extend(commits)
print(create_json_result(
gtema commented 2022-09-28 10:11:09 +00:00
Member
Copy Link

can you pls add argument to specify whether return yaml or json? human reading json is very bad

can you pls add argument to specify whether return yaml or json? human reading json is very bad
Ghost commented 2022-09-28 13:13:20 +00:00
Copy Link

We like json more, but yaml option added.

We like json more, but yaml option added.
Ghost added 1 commit 2022-09-28 12:04:38 +00:00
jobs added and archived pull requests removed c660386935
Ghost added 1 commit 2022-09-28 13:08:15 +00:00
add yaml option 14a8cfa18c
tischrei commented 2023-02-20 13:52:01 +00:00
Owner
Copy Link

not needed anymore

not needed anymore
tischrei closed this pull request 2023-02-20 13:52:01 +00:00
tischrei deleted branch attention_list 2023-02-20 13:52:06 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
gtema
Labels
Clear labels
gate
Gate it
gate
Gate it
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
A200014817 ansideln cicd ikvrivis magnus otcbot proposalbot sgode smartyno tischrei vhasko vladimirhasko vladimirvshivkov vvshivko zuul
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infra/otc-metadata#4
No description provided.
Delete Branch "(deleted):attention_list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?