infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

Additions to sbv confpy #123

Merged
zuul merged 2 commits from search_suggested_sbv into main 2023-07-27 12:28:44 +00:00
Conversation 5 Commits 2 Files Changed 1 +2
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/generate_doc_confpy.py
View File

@ -184,6 +184,8 @@ def process_repositories(args, service):
title=f"{service['service_title']} - Service Based View",
service_type=service["service_type"]
)
context["service_category"] = service['service_category']
context["service_title"] = service['service_title']
if not copy_path.exists():
vhasko commented 2023-07-25 19:38:58 +00:00
Outdated
Review
Copy Link

service_type is already present in context by previous context = dict(…) assignment why service_title is required if in context there’s already title key?

service_type is already present in context by previous context = dict(...) assignment why service_title is required if in context there's already title key?
sgode commented 2023-07-27 12:07:00 +00:00
Outdated
Review
Copy Link

service_type is already present in context by previous context = dict(…) assignment why service_title is required if in context there’s already title key?

The title includes the - Service Based View which results in that: https://gitea.eco.tsi-dev.otc-service.com/docs/elastic-cloud-server/src/branch/test-search-4/doc/source/conf.py#L101 However having the actual title of the service as data is needed for the search stuff. I’m not sure whether we use the title somewhere, so I’m not sure if simply removing the - Service Based View thingy would break anything. Generally that would work, but then SBV would be the only thing not having the service_title attribute.

> service_type is already present in context by previous context = dict(...) assignment > why service_title is required if in context there's already title key? > > The title includes the `- Service Based View` which results in that: https://gitea.eco.tsi-dev.otc-service.com/docs/elastic-cloud-server/src/branch/test-search-4/doc/source/conf.py#L101 However having the actual title of the service as data is needed for the search stuff. I'm not sure whether we use the title somewhere, so I'm not sure if simply removing the `- Service Based View` thingy would break anything. Generally that would work, but then SBV would be the only thing not having the service_title attribute.
logging.info("Path for sbv does not exist")
copy_path.mkdir(parents=True, exist_ok=True)