infra/otc-metadata
16
0
Fork 13
Code Issues 5 Pull Requests 1 Packages Releases Wiki Activity

removed environment: internal for ocr #204

Merged
zuul merged 3 commits from :ocr_public_release into main 2024-04-02 15:25:27 +00:00
Conversation 8 Commits 3 Files Changed 3 +1 -3
3 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 044cd16203 - Show all commits

2
otc_metadata/data/services/ocr.yaml
View File

@ -1,5 +1,5 @@
--- ---
environment: internal environment: public
vpruthi marked this conversation as resolved Outdated
sgode commented 2024-04-02 10:27:57 +00:00
Outdated
Review
Copy Link

Please don’t remove that but change it to public, we need this var. Changing it all to public is the better way to do it, but we only really require it on the service-level.

You can try building docsportal afterwards to see whether it works.

Please don't remove that but change it to `public`, we need this var. Changing it all to `public` is the better way to do it, but we only really require it on the service-level. You can try building docsportal afterwards to see whether it works.
vpruthi commented 2024-04-02 11:22:00 +00:00
Outdated
Review
Copy Link

Thank you @sgode for your feedback, added back environment: public on service-level to ocr.yaml

Thank you @sgode for your feedback, added back environment: public on service-level to ocr.yaml
repositories: repositories:
- environment: internal - environment: internal
repo: docs/optical-character-recognition repo: docs/optical-character-recognition